Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3 Exports Cleanup #11519

Merged
merged 3 commits into from
May 6, 2016
Merged

B3 Exports Cleanup #11519

merged 3 commits into from
May 6, 2016

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented May 5, 2016

moves old export view to b3 in the interim while the new one is being QA'd
did a soft QA locally and will do one on staging as well. After that will remove the hold off on merge label

@orangejenny
cc @nickpell

screen shot 2016-05-05 at 6 23 33 pm

@biyeun biyeun added the Open for review: do not merge A work in progress label May 5, 2016
@biyeun biyeun removed the Open for review: do not merge A work in progress label May 6, 2016
@biyeun
Copy link
Member Author

biyeun commented May 6, 2016

Tested this out pretty thoroughly on staging and no js errors. I saw on @nsclark's testclark domain, but those (I checked) were unrelated to these changes.

@orangejenny
Copy link
Contributor

looks good

@orangejenny orangejenny merged commit c6c9afc into master May 6, 2016
@orangejenny orangejenny deleted the b3-exports-cleanup branch May 6, 2016 12:58
@benrudolph
Copy link
Contributor

one thing that kind of stands out to me is the move of "Show deleted questions." it's much more prominent in this layout when it's a pretty insignificant button for most users. only useful for those more advanced. might make more sense to have it on the right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants